FS#2178 Empty pagename in internal links doesn't work in the root namespace

2011-02-19 Michitux

When I add links like [[ ]] or [[?do=index]] they are displayed as red although they have the name "start" and the start page exists (but they also don't display the title of the start page although useheading is enabled). In other namespaces this syntax does work and [[#test]] does work in all namespaces, too.

2011-03-20 Izidor

My solution which treat an empty page address as link to the current page. (Details were discussed with Michael on IRC.

0001-If-the-page-link-is-empty-it-should-link-to-current-.patch text/plain

2011-03-21 Michitux

I think the check for "" should be after the check for the hash as otherwise something like #test won't work.

2011-03-21 Izidor

Cases like #test are handled correctly. DokuWiki in those cases skip the condition and the page part of address is empty. However the hash part stays and is handled normal way. In other words, when I have #test, the difference is in links => href="#text" vs href="my:space#text" (for page "my:space")

My testing wiki produces following html
<wiki>
#test >> [[#test]] <<

empty >> [[ ]] <<

?do=index >> [[?do=index]] <<

namespace link >> [[my:]] <<
</wiki>

<html>

#test » <a href="#test" title="my:space &crarr;" class="wikilink1">test</a> «



empty » <a href="/dokuwiki/doku.php?id=my:space" class="wikilink1" title="my:space">start</a> «



?do=index » <a href="/dokuwiki/doku.php?id=my:space&do=index" class="wikilink1" title="my:space">start</a> «



namespace link » <a href="/dokuwiki/doku.php?id=my:start" class="wikilink2" title="my:start" rel="nofollow">my</a> «

</html>

2011-03-26 andi

Could you add unit test cases?

2011-04-04 Izidor

There are unit test cases based from my comment above.

0002-Unit-test-cases-for-FS-2178.patch text/plain

2011-04-06 andi

Michitux, since you discussed this with Izidor already, can you have a look and apply if it's okay?

2011-04-07 Michitux

At least some of the test cases are failing here:

Fail: /home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php -> xhtml_links_test -> test_empty_internallink -> Equal expectation fails at character 29 with [<a href="./doku.php/my/space" class="wikilink2" title="my:space" rel="nofollow">start</a>] and [<a href="/./doku.php/my:space" class="wikilink1" title="my:space">start</a>] at [/home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php line 57]
Fail: /home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php -> xhtml_links_test -> test_empty_internallink_with_caption -> Equal expectation fails at character 29 with [<a href="./doku.php/my/space" class="wikilink2" title="my:space" rel="nofollow">my caption</a>] and [<a href="/./doku.php/my:space" class="wikilink1" title="my:space">my caption</a>] at [/home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php line 72]
Fail: /home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php -> xhtml_links_test -> test_empty_internallink_index -> Equal expectation fails at character 29 with [<a href="./doku.php/my/space?do=index" class="wikilink2" title="my:space" rel="nofollow">start</a>] and [<a href="/./doku.php/my:space?do=index" class="wikilink1" title="my:space">start</a>] at [/home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php line 87]
Fail: /home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php -> xhtml_links_test -> test_empty_internallink_index_with_caption -> Equal expectation fails at character 29 with [<a href="./doku.php/my/space?do=index" class="wikilink2" title="my:space" rel="nofollow">my caption</a>] and [<a href="/./doku.php/my:space?do=index" class="wikilink1" title="my:space">my caption</a>] at [/home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php line 102]

I think explicitly setting the configuration options the involved functions use should solve the problem, Izidor, could you please adjust the test cases accordingly? Also assuming that rewriting is set to internal rewriting probably doesn't work. (Btw. these problems are part of the reasons why I want to have a better testing system...)

Another suggestion: Add the test cases to pageutils_resolve_pageid.test.php - then you don't have the problems of different URLs and it's probably also the test where the new test cases fit best.

Concerning the actual change: I think implementing the fix the way you have implemented it and using my suggestion are two possible options, as you've submitted the patch I think I'll apply your patch if there shouldn't be any reasons why to do it differently.

2011-04-07 Izidor

I added every configuration directive which could influence the test. Also added direct test cases for resolve_pageid() (I missed that somehow). (Apply this patch after applying the page 0002-Unit...

0003-Added-configuration-variables-for-empty-link-testcas.patch text/plain

2011-04-07 Izidor

Forget to mention that one test case fails. The change does not have influence on that. (Examined on a freshly cloned DokuWiki)

2011-04-07 Michitux

That looks already much better, but the tests are still failing because the pages exist/don't exist:

FAIL->./cases/inc/parser/xhtml_links.test.php->xhtml_links_test->test_empty_internallink->Equal expectation fails at character 69 with [<a href="/./doku.php?id=my:space" class="wikilink2" title="my:space" rel="nofollow">start</a>] and [<a href="/./doku.php?id=my:space" class="wikilink1" title="my:space">start</a>] at [/home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php line 63]
FAIL->./cases/inc/parser/xhtml_links.test.php->xhtml_links_test->test_empty_internallink_with_caption->Equal expectation fails at character 69 with [<a href="/./doku.php?id=my:space" class="wikilink2" title="my:space" rel="nofollow">my caption</a>] and [<a href="/./doku.php?id=my:space" class="wikilink1" title="my:space">my caption</a>] at [/home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php line 85]
FAIL->./cases/inc/parser/xhtml_links.test.php->xhtml_links_test->test_empty_internallink_index->Equal expectation fails at character 82 with [<a href="/./doku.php?id=my:space&do=index" class="wikilink2" title="my:space" rel="nofollow">start</a>] and [<a href="/./doku.php?id=my:space&do=index" class="wikilink1" title="my:space">start</a>] at [/home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php line 107]
FAIL->./cases/inc/parser/xhtml_links.test.php->xhtml_links_test->test_empty_internallink_index_with_caption->Equal expectation fails at character 82 with [<a href="/./doku.php?id=my:space&do=index" class="wikilink2" title="my:space" rel="nofollow">my caption</a>] and [<a href="/./doku.php?id=my:space&do=index" class="wikilink1" title="my:space">my caption</a>] at [/home/michitux/pub/projekte/dokuwiki/_test/cases/inc/parser/xhtml_links.test.php line 129]

2011-04-07 Izidor

I added checks if a page exists or not. Also figured out that for empty link it put $conf['starter'] instead of the name of page -- it is solved in the patch...

0004-Check-if-link-exists-and-set-right-caption.patch text/plain

2011-04-08 Michitux

Fix provided by Izidor Matušov applied in c006739e and fda14ffc

FS#2178 Empty pagename in internal links doesn't work in the root namespace

Syntax