FS#2890 Wrong description "UTF-8 or latin-1" of plugin»authad»sso_charset setting

ACL & Authentication

• 

  2013-11-28 pabouk

  The foollowind parameter plugin»authad»sso_charset of the Authad plugin has this description:
  ---
  The charset your webserver will pass the Kerberos or NTLM username in. Empty for UTF-8 or latin-1. Requires the iconv extension.
  ---
  
  This does not make sense. UTF-8 does not have the same codes -- neither as ISO Latin-1 (ISO 8859-1) nor as Windows-1252 (also being called Latin-1 sometimes). UTF-8 has the same codes as whole ASCII and Latin-1 up to the code 127 so in the text there should probably be "UTF-8 or ASCII".
• 

  2013-11-28 andi

  Yes it does make sense. The code checks if valid UTF-8 is supplied - if not it assumes latin1 and calls utf8_encode() on it.