FS#2429 very hight memory consumption when uploading files (~30MB)

Media Management

• 

  2012-01-16 flokli

  When I try to upload a bigger file (PDF of ~30 MB), the Media Manager simply says "Failed" after going to 100%.
  
  apache error log says:
  
  [Mon Jan 16 16:00:36 2012] [error] [client xx.xxx.xxx.xxx] PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 38473246 bytes) in /var/www/xxxxxxxxx/htdocs/lib/exe/ajax.php on line 11, referer: http://xxxxxxxxx/start:cat1?do=media
  
  
  
  134217728 bytes mean 128MB. Thats really a lot of overhead! Can you optimze the code so that it won't consume so much RAM?
• 

  2012-01-16 andi

  Interesting, this line was assumed to be dead code and we planned to remove it in a future release. Can you tell what browser (and exact version) you use? Also which PHP version do you use?
• 

  2012-01-16 flokli

  Browser: Chromium 16.0.912.63
  PHP: 5.3.8 without FastCGI or something like that
  Dokuwiki on git 4fcd684a
  
  Upload also failed on Firefox 9.0.1, but I don't know if the error occurs on the same line.
  
  When I raised the memory limit, the upload worked.
  
  upload_max_filesize = 200M
  post_max_size = 200M
  memory_limit = 128M (raised to 1024M, but that's of course too much)
• 

  2012-01-16 andi

  Even more interesting :-) Can you remove the following lines from lib/exe/ajax.php and report back if that fixes the problem for you?
  
  //fix for Opera XMLHttpRequests                                                
  if(!count($_POST) && !empty($HTTP_RAW_POST_DATA)){                              
     parse_str($HTTP_RAW_POST_DATA, $_POST);                                    
  }
• 

  2012-01-16 flokli

  Yup, that fixed it for me.
  
  Upload worked successfully with the memory limit of 128M.
  File is stored where it should be :-)
  
  diff --git a/lib/exe/ajax.php b/lib/exe/ajax.php
  index 46d8351..3d15842 100644
  --- a/lib/exe/ajax.php
  +++ b/lib/exe/ajax.php
  @@ -6,11 +6,6 @@
   * @author     Andreas Gohr <andi@splitbrain.org>
   */
  
  -//fix for Opera XMLHttpRequests
  -if(!count($_POST) && !empty($HTTP_RAW_POST_DATA)){
  -    parse_str($HTTP_RAW_POST_DATA, $_POST);
  -}
  -
  if(!defined('DOKU_INC')) define('DOKU_INC',dirname(__FILE__).'/../../');
  require_once(DOKU_INC.'inc/init.php');
  //close session
• 

  2012-01-17 flokli

  What should I do now?
  Add a pull request? Or will  you commit it?
• 

  2012-01-18 andi

  fixed in 29e4fe3d
• Related tasks:
  • FS#2071 Check the need for Opera XHR bugfixing