FS#2395 A Link Wizard popup gets rendered/opens for *every* existing <div class="dokuwiki">

CSS, XHTML, JS, Browsers

• 

  2011-11-27 AndiH

  In FS#2394 (http://bugs.dokuwiki.org/index.php?do=details&task_id=2394) I already described,
  that the Link Wizard popup appears multiple times when opened in some templates. This is
  especially true for vector and monobook (cf. attached screenshots).
  
  
  ====== How to reproduce: ======
  1. Use a template with multiple occurrences of <div class="dokuwiki"> (e.g. current vector release
    or development version at https://github.com/andreashaerter/dokuwiki-template-vector/zipball/master)
  
  2. Open DokuWiki's editor (example.com/?do=edit)
  
  3. Click on the internal link wizard icon
  
  
  ====== Expected result ======
  Single, working link wizard popup opens.
  
  
  ====== Current result ("Bug") ======
  Multiple popups are open (one for every existing <div> with CSS class "dokuwiki"), only one is working
  (cf. screenshots).
  
  
  ====== Misc ======
  Tested with Firefox 8 and Chrome 15 on Linux.
  

  • 02-monobook.png image/png; charset=binary
  • 03-vector.png image/png; charset=binary
• 

  2011-11-27 AndiH

  The problem is the following call because you just can't be sure the element is unique:
  ".appendTo('div.dokuwiki')" (see https://github.com/splitbrain/dokuwiki/blob/c798b23bcedefa974e4af474904e4e24cdad67d5/lib/scripts/linkwiz.js#L44 ).
  E.g. the vector and monobook templates are using '<div class="dokuwiki">' for every navigation box in the sidebar.
  
  Possible solution: use another, *unique* element which is existing in every case. I tested ".appendTo('#tool__bar');" with Firefox 8, Chrome 15 @ Linux; MSIE 8 @ WinXP. It seems to work without any problems.
• 

  2011-11-28 ploeger

  I just made a pull request, which uses div#bodyContent as a parent, but asked to review it, because I'm not sure, wether this one's "unique enough" and overall fitting for the purpose.
• 

  2011-11-28 ach

  #bodyContent is a bad idea, because that doesn't exist in every template. #tool__bar would be better ... or maybe just *the first* .dokuwiki?
• 

  2011-11-28 ach

  As we were using $('.dokuwiki:first') somewhere else already, I fixed it using that.
• 

  2011-11-28 ach

  fixed in 04dd9c85
• 

  2011-11-29 AndiH

  $('.dokuwiki:first') works prefect. I tested it with all of my templates and IE 6,7,8,9, newest Opera/Chrome/Firefox :-). Thanks for the quick fix.