FS#2370 get groups from ldap not correct with $conf['auth']['ldap']['mapping']['grps']

ACL & Authentication

• 

  2011-11-10 ddarras

  Hello,
  
  I'm using the ldap authentication with groups defined the user attribute "edupersonaffiliation". In my conf :
  
  $conf['auth']['ldap']['mapping']['grps'] = array('edupersonaffiliation' => '/(.*)/i');
  
  When authenticated, here is a list of groups i get from a person :
  
  
  Group: employee  --> value from attribute edupersonaffiliation : ok
  Group: member    --> value from attribute edupersonaffiliation : ok
  Group: 2         --> nok
  Group: user      --> default group : ok
  
  The value "2" comes from the count key in the result set from ldap search. Here is the culprit :)  :
  
  ldap.class.php/getUserData
  
  if($user_result[$key]) foreach($user_result[$key] as $grp){
                         if (preg_match($regexp,$grp,$match)) {
                             if($localkey == 'grps') {
                                 $info[$localkey][] = $match[1];
                             } else {
                                 $info[$localkey] = $match[1];
                             }
                         }
                     }
  
  Here is a proposition to solve this issue :
  
  if($user_result[$key]) foreach($user_result[$key] as $grpKey => $grp) {
  if($grpKey !== 'count')
            if (preg_match($regexp,$grp,$match)) {
                if($localkey == 'grps') {
                    $info[$localkey][] = $match[1];
                } else {
                    $info[$localkey] = $match[1];
                }
            }
  }
  
  Best regards
  David
• 

  2013-09-20 Klap-in

  New here is the check: if($grpKey !== 'count')
  
  Reading docs at http://php.net/manual/en/function.ldap-get-entries.php gives me the impression that 'count' is an usual entry.
  
  So i think this is logic fix.
• 

  2013-09-20 Klap-in

  Implemented by https://github.com/splitbrain/dokuwiki/pull/345
• 

  2014-02-16 Klap-in

  Fixed via PR in comment