FS#2256 Some mistake while parsing http response in HTTPclient.

other

• 

  2011-05-12 onborodin

  Some mistake while parsing http response in HTTPclient.
  From this, for example, don't work rss reader.
  
  Fast patch:
  --- HTTPClient.php.orig 2011-05-12 13:06:10.000000000 +0300
  +++ HTTPClient.php      2011-05-12 13:05:38.000000000 +0300
  @@ -384,7 +390,7 @@
          }
  
          // get Status
  -        if (!preg_match('/^HTTP\/(\d\.\d)\s*(\d+).*?\n/', $r_headers, $m)) {
  +        if (!preg_match('/^HTTP\/(\d\.\d)\s*(\d\d\d).*?[\r\n]/', $r_headers, $m)) {
              $this->error = 'Server returned bad answer';
              unset($this->connections[$connectionId]);
              return false;
  
• 

  2011-05-18 adrianlang

  Correct lineending according to http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4 is CRLF = \r\n. Actually, the old Regexp matches everything but a single \r as line ending, which probably is really unusual.
• 

  2011-07-08 andi

  Can you give an example URL where the original regex is problematic?
• 

  2011-10-15 andi

  no feedback given