FS#2250 E-mail notification fails if editor's username is substring of subscriber's username

Backend

• 

  2011-05-09 strave

  Let users foobar, barfoo and fooo be subscribed to email notifications on changes of page X.
  
  Suppose user foo changes X, then fooo gets notified but not foobar and barfoo since foo is a substring of foobar and barfoo.
  
  The problem lies within subscription_addresslist and subscription_regex in subscription.php, where the following regular expression is built to match subscribers in the .mlist files:
  
  /^((?:(?!foo)\S?)+)(?: every(?: (\S+))?)?$/
  
  A possible correction would be to match
  
  /^((?:(?!foo ))\S+)(?: every(?: (\S+))?)?$/
  
  instead.

  • subscription.patch text/plain
• 

  2011-05-22 Michitux

  Your suggestion matches a single "foo" on a line (which is iirc the syntax of old subscription files). Furthermore I don't think that the non-capturing subpattern around the lookahead pattern is needed. My suggestion that I'll commit/push in a few minutes is:
  
  ^((?!foo\b)\S+)(?: every(?: (\S+))?)?$
  
  Explaining the first part of the pattern a bit: a) it is a subpattern ( () around it) b) the negative lookahead pattern is checked: the username and a word boundary. The word boundary can also be the end of the string. If the lookahead pattern fails, the whole branch we are currently in - which is in this case the whole pattern - fails. c) Now that we know that this subscription line should be matched non-whitespace is matched as in the default case.
• 

  2011-05-23 Michitux

  Fixed in 6c30366e .
• 

  2011-05-23 Michitux

  Looks like I've still missed a case - users with names like foo.bar where the "." is a word boundary, too. I've replaced \b by (?: |$) now, this seems to work.