FS#2120 plugin manager skips plugin installation for existing plugins w/o a proper notification of the user

Plugins

• 

  2010-12-13 cluster

  If for installed plugins the update link changed (like more or less recently when a lot of plugin developers switched to git) the update button int he plugin manager does not work. Copying the new URL into the respective form field and using the download button does //not// help, since the installation is skipped with the message: "Plugin package (0 plugins: ) successfully installed." The reason for skipping is the $overwrite=false setting in ap_download.class.php, preventing the installation of new plugins to overwrite existing plugins/templates.
  
  This is at odds with the documentation which states for exactly this situation:
  
  http://www.dokuwiki.org/plugin:plugin#installing_a_plugin_from_a_remote_url
  
  "...Note: This only works when the plugin maintainer always uses the same URL for the plugin or provides some redirection to the latest version through a common URL. //If this is not the case just get the new URL and install it like a new plugin. The Plugin Manager then will update your old plugin.//" (emphasis added)
  
  Attached is a small patch with an additional notification of the user.
  
  

  • ap_download.class.php.patch text/plain
• 

  2010-12-26 lupo49

  There should be a new localization variable defined in inc/lang/$LANG/lang.php for the error message.
• 

  2011-02-06 andi

  Rather than the proposed patch, I changed the behaviour to match the documentation.
• 

  2011-02-06 andi

  fixed in 7cb9f9ee