FS#1983 wl() adds an additional slash in front if $conf["userewrite"]=".htaccess" and $conf["useslash"]=1

other

• 

  2010-06-26 AndiH

  As the title said, wl() (see <http://bit.ly/cKqwiA>) add an additional slash in front if
  
   $conf["userewrite"]=".htaccess";
   $conf["useslash"]=1;
  
  Instead of "/foobar/page/", you'll get "//foobar/page" -> a link e.g. Firefox is not able to parse as a relative one. Setting param 3 to TRUE produces "http://example.com//foobar/page" instead of "http://example.com/foobar/page".
  
  I discovered this after a user of the vector template (<http://www.dokuwiki.org/template:vector>) reported that the "Article"-tab does not work when rewriting is active.
  The vector template brings native support for the translation plugin (<http://www.dokuwiki.org/plugin:translation>), and newer plugin versions are creating wrong links, too.
  
  I wondered why it works in monobook (<http://www.dokuwiki.org/template:monobook>) and discovered, that I used html_wikilink() (<>) there, which does not have this problem. html_wikilink() (<http://bit.ly/cI8yfq>) is using Doku_Renderer::_internallink() (<http://bit.ly/dopD9o>). Same with the translation plugin: html_wikilink() was replaced by wl() (see <http://bit.ly/bXYX6P>).
• 

  2010-06-26 AndiH

  Ok, you may close this. After doing some testing + some hints by Michitux on IRC (see <http://irc.dokuwiki.org/index.php?d=2010-06-26>), I found out that I used wl() the wrong way (the translation-plugin does it the wrong way, too). Therefore this is a template:vector and plugin:translation bug, not a wl() one.
  
  
  Maybe this small conclusion is useful for someone:
  
  My error is rooted in the different behavior of wl() and html_wikilink(). If $conf["userewrite"] and $conf["useslash"] is set to 1 (wiki installed on <http://example.com/dokuwiki>),
  - wl(":start") leads to "/dokuwiki//start"
  - html_link(":start) leads to "<span class="curid"><a href="/dokuwiki/start" class="wikilink1" title="start">start</a></span>
  
  The error is: page IDs have to be cleaned before using them with wl() (-> removes the leading ":"), like it also has to be done for e.g. for auth_quickaclcheck():
  - If your IDs are absolute already, run them through cleanID() before passing to wl()
  - If your IDs are not absolute, use resolve_id() first
  - wl() does no cleaning itself