FS#1921 Undesirable behavior copy/pasting from Python code blocks

Plugins

• 

  2010-03-17 petey

  I hope this hasn't been brought up elsewhere, as I couldn't find this issue in past posts/reports, but this "bug" essentially concerns undesirable behavior when copy/pasting from a code block on a wiki page:
  
  When creating a Python code block using <code python> ... </code> on a Mac OS X Snow Leopard machine, and viewing the resulting page in either Firefox or Safari, lines that are supposed to be blank consist of a space in the rendered page.
  
  This has the unfortunate consequence that indented Python code blocks (that ever-beloved feature of Python) won't copy/paste nicely, as e.g.
  
  test = 0
  for i in xrange(10):
     test += i
  #a space is automatically present on this line even though it should have no spaces
  for i in xrange(10):
     test += i
  
  will not proceed smoothly to the second for loop, but will return an IndentationError.
  
  Can the Python code parsing module be set to remove this feature, as spaces are very important in Python and the current behavior interferes with the usage of Python code? It may be a feature of HTML, as Python code on e.g. Wikipedia, where e.g. http://en.wikipedia.org/wiki/Viterbi_algorithm has completely un-copy/pastable behavior as well.
  
  I'm very new at this, but let me know if I can do anything to help!
• 

  2010-03-17 ChrisS

  This is a geshi issue.  Fwiw, the downloadable code block is fine.
• 

  2010-03-17 petey

  Yes, that's the workaround I'm using, but there must be a more elegant way. Commenting out line 3905 in the geshi.php that's included with DokuWiki ($code[$i] = '&nbsp;';) in the following for loop for all lines of code:
  
  if ('' == trim($code[$i])) {
                     //$code[$i] = '&nbsp;';
                 }
  
  (NB: there's an identical block at line 3765 which won't do it) will fix the "problem" as I've outlined it, but only in the "Preview" pane of the DokuWiki editor. Is there a different geshi routine called for the actual rendering? I don't speak PHP, so I'm stabbing in the dark here, but there must be a solution out there somewhere...
• 

  2010-03-17 petey

  Actually, I take that back -- as long as you make a change to the page and save it the above will work. (I guess it forces a re-rendering from a cached page? Or makes Safari not use its cached page, more likely...)
  
  That said, commenting out line 3765 presumably does the same for those who use the line numbering feature of geshi.
  
  And with *that* said, even more importantly: I don't know what the above fix will break (if anything), but it does what I want it to do, at least.
  
  Thanks for pointing me to the geshi module, ChrisS!
• 

  2010-03-17 ChrisS

  Because its geshi, a third party package - its highly unlikely DokuWiki will make any changes.  It would make updating for new geshi versions too complex.  You should get in touch with geshi people and raise the issue with them.  If they fix the problem, you can then push DokuWiki to update geshi.
• 

  2010-06-27 andi

  works for me in current devel. probably fixed upstream