FS#1821 change ?do=revisions behaviour to use GET method

Backend

• 

  2009-12-16 glen

  please change ?do=revisions behaviour to use GET method,
  so that i can use the URL and give it to friend so he can see the differences i had in mind.
  
  so the url would be ?do=revisions&r1=1260957854&r2=1260957854
  
  and it would display diff between versions
  rev=1260957854 and rev=1260957854  
• 

  2010-01-10 izmestev

  it works already:
  http://www.dokuwiki.org/requirements?do=diff&rev2[]=1261432652&rev2[]=1263113987
• 

  2010-01-11 glen

  that's helpful, but it doesn't complete the feature request. you still have to hack and sniff around to get the proper link.
  
  as the ui itself gives just url to http://www.dokuwiki.org/requirements?do=diff as the method is POST, not GET
• 

  2010-01-11 izmestev

  Sorry for mistake, now I understand what you want.
  
  I think need add parameter  $method="get" into Doku_Form constructor call at http://dev.splitbrain.org/reference/dokuwiki/nav.html?inc/html.php.source.html#l426
  
  $form = new Doku_Form(array('id' => 'page__revisions'), $method="get");
  
• 

  2010-01-11 glen

  not precisely, making all form data as GET will make the url very ugly and noisy. only OLDREV and NEWREV should be there....
  
  ?sectok=eafe4f6702abf8194b2060177f0d8f59&rev2[]=1263212232&rev2[]=1263212196&do[diff]=Show+differences+between+selected+revisions
  
  vs:
  
  ?r1[]=1263212232&r2=1263212196
• 

  2010-01-11 glen

  adding $GET params support for $r1 and $r2 is trivial, but making diff links mixed GET/POST needs bigger rewrite

  • task-1821.patch text/plain
• 

  2010-01-11 izmestev

  And where is difference between
  ?do=diff&rev2[]=1261432652&rev2[]=1263113987
  and
  ?do=diff&r1=1261432652&r2=1263113987
  
  I thought that you want to see direct url after submitting revisions form.
• 

  2010-06-27 foosel

  The diff output now contains a permalink which can be used for sharing diffs