FS#1534 MEDIA_DELETE_FILE event trigger in media.php: advise_after() never reached when deletion successful

Backend

• 

  2008-11-20 jaredm

  In media.php, function media_delete():
  
  171          $evt = new Doku_Event('MEDIA_DELETE_FILE',$data);
  172          if ($evt->advise_before()) {
  173              if(@unlink($file)){
  174                  msg(str_replace('%s',noNS($id),$lang['deletesucc']),1);
  175                  $del = io_sweepNS($id,'mediadir');
  176                  if($del){
  177                      // current namespace was removed. redirecting to root ns passing msg along
  178                      header('Location: '.DOKU_URL.'lib/exe/mediamanager.php?msg1='.
  179                              rawurlencode(str_replace('%s',noNS($id),$lang['deletesucc'])));
  180                      exit;
  181                  }
  182                  return true;
  183              }
  184          }
  185          $evt->advise_after();
  186          unset($evt);
  
  If the file deletion is successful, you'll never reach line 185, so any plugins registering to receive the event "AFTER" it occurs will never get called.
• 

  2008-11-20 jaredm

  Also, it'd be good if the event send the full media pagename with namespace... add "$data['id'] = $id;" before triggering the event.
• 

  2009-01-17 chi

  Implemented in devel as of 2009-01-17.