-
2011-11-20
ach
Whenever your screen is too small (e.g. only 650px high with the default template, other templates can be much more), you won't be able to use the image diffs "Shine-through" and "Swipe" of the fullscreen mediamanager.
The JS includes the fallback to *not* resize the panels whenever the screen is too small. But whenever this kicks in, the image diff views are not visible, because they get resized to a ridiculous small height (13px with the default template in my environment).
-
2011-12-01
ploeger
Hmm... I think, we could set a min-height to some value (100px?) of the "mediamanager__diff"-div. The problem is IMHO, that the image-divs are directly laying on each other to achieve the effect, but thus not creating a block, that can set a height. Perhaps the google student, who did this, could take a look?
I would probably set the min-height and commit and add a task for the next version.
-
2011-12-04
ach
Setting min-height would sort of work but not really fix it. But your remark about the image divs laying on top of each other gave me the right clue: The problem was that they were both absolutely positioned, which makes them impossible to have their natural height. But as only one of them needs to be absolutely positioned to create the overlay effect, I fixed it in 449428695c0293a45517a610cf97193094f7a8b1.
But I found another problem: Now the fallback to to resize the panels whenever the screen is too small *doesn't work anymore*. I could have sworn, it used to work. Not sure what is causing it...
-
2011-12-04
ach
Okay, the reason for the resize fallback not working is because 'dw_mediamanager.view_opts.list' is undefined...
-
2011-12-04
ach
Fixed. The second problem was there because I was not in the "Media Files" tab and therefore some JS variable which depended on something in there was not available.
-
2011-12-04
ach
-
Related tasks: