FS#2376 media revisions not using recent_days config

Media Management

• 

  2011-11-12 ach

  The recent revisions show media revisions which are older than the page revisions. Could it be that $conf['recent_days'] is either not used by the media revisions or used in a different way?
  
  See an example here: http://www.dokuwiki.org/?do=recent&id=start&show_changes=both&first%5B120%5D=less+recent+%3E%3E
  There you can see changes to media files from 2010.
• 

  2011-11-28 ploeger

  The problem here is, that there are not more than the configured "recent" media files in the changelog. Therefore, the indexer in line #70 just skips trimming. I'll post that to the mailing list to see, if it's an expected behaviour.
• 

  2011-11-28 ach

  Do we have the same behaviour if you have less than the configured recent changes in *pages* as well? If yes, I'd say "Won't fix". If no, it shouldn't behave differently and should be fixed.
• 

  2011-11-29 ploeger

  Reading the code I THINK it should work. I don't know. Andi, could we temporarily alter the recent-parameter on the official dokuwiki to check this or can we built up a test dokuwiki by copying the real one? (I think, the official dokuwiki is the best testing candidate because of its massive changelog)
• 

  2011-12-04 ach

  Testing this in a local installation should be enough. (You shouldn't need a massive changelog to test it.)
• 

  2011-12-07 Michitux

  I've just read through the code and exactly the same code is used for both changelogs (just the file name is set differently at the beginning of the function), so the behavior should be consistent. On my homepage I've also changes from some months ago in the recent changes even though recent_days is 30, so from what I see there the behavior is as intended in the code, 20 entries are saved in the changes as configured in the "recent" configuration option. Thus the behavior is:
  
  - keep at least "recent" entries in the changelog
  - additional entries are removed when they are older than recent_days
  
  At least in the German translation this is not really obvious from the description of the configuration options, so maybe this should be clarified.
• 

  2011-12-09 ach

  Okay, thanks for checking. I will close this task as this proves it's not a bug but the intended behaviour.