FS#1668 $_SERVER['REMOTE_ADDR'] is incorrectly used in many places to provide the client ip address

$_SERVER['REMOTE_ADDR'] doesn't supply an accurate client IP address when the web server is behind a reverse proxy. Dokuwiki already has a sophisticated function clientIP() (inc/common.php) to determine the clientIP address. It or the value in $INFO['client'] should be used instead of $_SERVER['REMOTE_ADDR'] in most if not all cases.

Some places where $_SERVER['REMOTE_ADDR'] is used for the client IP address:

checkwordblock() inc/common.php
addLogEntry() inc/changelog.php

there are probably others.

[ NOTE: If there are to be more calls to clientIP() it maybe worth caching the results of the first call. ]

FS#1668 $_SERVER['REMOTE_ADDR'] is incorrectly used in many places to provide the client ip address

Backend