FS#1381 Spellchecker broken in 2008-04-10 release, working on rc2008-03-31

Plugins

• 

  2008-04-12 jep3

  Spell check does not work on DokuWiki development snapshot version 2008-04-11 and spellcheck-2008-04-11.tgz.  It also did not work on 2008-04-10 pair.
  NO other plugins were installed to test this before filing this bug report.  
  Clean install just to test this.  Will do another if/when requested.
  
  However spell check with DokuWiki rc2008-03-31 and spellcheck-plugin-2007-11-23.tgz DOES work.
  
  Also DokuWiki 2007-06-26b with its built in spell check works (and is a wonderful feature).
  
  All three Wikis are on the same box, under the same www/HTML tree.  Each has a different name, but that is the only difference.  It's my personal computer, so I have full admin rights.
  
  My Linux install is, Cent-OS 5, Kernel 2.6.18-53.1.4.el5, i686, running on Intel Pentium 4
  FireFox 1.5.0.12 with Sun JRE installed, PHP 5.1.6 32Meg RAM available
  English with aspell installed.  FireFox 2.x on Windows XP (With Sun JRE) also fails.
  FireFox 1.5.0.10 on CentOS 4 NO Sun JRE also fails.
  
  Now if only I had a life so I was not submitting this on a Friday night in Florida, USA.
  Hopefully I won't hear from Andreas until next week :), that means he has a life.
  
  
• 

  2008-04-12 foosel

  Tested on a current devel snapshot got via "darcs get" this morning, which equals the rc as of yesterday and the spellcheck-plugin as available at http://wiki.splitbrain.org/plugin:spellcheck, I cannot confirm this. Server runs Debian Etch/Sid, Kernel 2.6.24-1-amd64, FF 2.0.0.12, PHP 5.2.5-3 (+ suhosin), Apache 2.2.8.
  
  Could you maybe give a hint as to what exactly does not work? Does the button in the toolbar not show up, does it simply not do a thing when clicked (not even changing its logo), etc.?
• 

  2008-04-14 jep3

  Thank you Gina Haeussge for your prompt reply.  Generally I only use the
  nightly archives at
    http://dev.splitbrain.org/browse/snapshots/
  I may have to over come my resistance to installing/learning DARCS.
  
  I apologize for not being clear, the spell check icon does not show up.
  I never use hot keys, so if the icon is missing, I assume the feature is
  not present.
  
  However, the nightly build 2008-04-14 DOES work.  Comparing
  the file trees, the only difference I see is the spellcheck/images dir now
  has files in it, and the spellcheck/lang tree is now populated.
  
  Why the nightly build of 2008-04-11 is missing these files is unknown
  to me, but EVERYTHING else is the same.
  
  There does seem to be a rendering problem when spell check is used with
  this release, but that is why I switched to the newer builds.  I suspect
  that this bug may have already been reported, or is an a glitch in my
  environment.  Its late tonight, tomorrow I will check properly (with
  several test files and different browsers, plus search fly spray before
  creating a bug report on rendering during spellcheck.  It may just be me.
  
  Closing this as it appears fixed, even if there are no notes I know
  about explaining what happened.
  
• 

  2008-04-14 foosel

  If the rendering issue you are experiencing happens to have something to do with the linkcolor of wrong words, I noticed that too during my tests. Although I don't understand why, the CSS as defined in stylesheet of the plugin does not match the links used for indicating wrong words, inserting the id of the spell__result div fixes this though (why is beyond me and my css knowledge, I always thought what I see in the style.css of the plugin is perfectly valid for the purpose...). I attached a patch (diff -ruN, not darcs) that "fixes" this, but I don't know if this is the right way.

  • spellcheck_style.patch text/plain
• 

  2008-04-14 ChrisS

  :hover, :link, :visited, :active count as pseudo classes, they rate equivalent to classes in the CSS cascade.  So, "div.dokuwiki a:visited", "div.dokuwiki a:link" have equivalent specificity to div.dokuwiki a.spell_error.  When specificity is equivalent, later rules win.  DokuWiki's standard styles always come after plugin styles, so dokuwiki's styles win.
  
  DokuWiki's styles should probably come before plugins to make it easier for a plugin to override them.  
  
  Best solution is most likely to use div.dokuwiki #spell__result a.spell_error, which I guess is what you have done.
• 

  2008-04-19 jep3

  Ummmmm, turns the formatting issues I "thought" I saw WERE me, by clearing my Browser's cache,
  and re-starting Firefox, things worked fine.  The problem I had seen was FAR more than bad
  link color, but in the end it was just browser weirdness.
  
  BUT, Gina Haeussge you are 100% right.  I had assumed the very light grey highlight for
  mis-spellings was 'the new way', annoying, but such is life.  If I apply your patch, then
  the mis-spelled words are once again a nice, visible red.
  
  Patch is valid for both 2008-04-17 and current 2008-04-19.  Probably no one else is following
  discussion of a fixed bug.  I will see how I can promote this so your fix gets into the release.
  
  To Christopher Smith, I suspect that DokuWiki standard styles come after plugin style so that
  custom site theme's can change them.  Other wise every plugin would have to know about every
  site theme, and what color choices are desired.  The current behavior simply requires a
  site theme to add a case for the spellchecker.